Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL] Make void functions return Future #14

Closed
Ascenio opened this issue Jul 1, 2021 · 2 comments · Fixed by #15
Closed

[PROPOSAL] Make void functions return Future #14

Ascenio opened this issue Jul 1, 2021 · 2 comments · Fixed by #15

Comments

@Ascenio
Copy link
Contributor

Ascenio commented Jul 1, 2021

There are some functions, mainly in SessionController where it returns void but is actually async, which means the client won't wait for operations. In the AgoraClient's _initAgoraRtcEngine() it doesn't catches errors because of this.
@Meherdeep
Copy link
Contributor

Thanks @Ascenio for all your suggestion. We will look into it.

Feel free to create a PR for the same if you want.

@Ascenio Ascenio mentioned this issue Jul 1, 2021
Merged
23 tasks
@tadaspetra
Copy link
Contributor

Changes merged in #15

@mohit41999 mohit41999 mentioned this issue Oct 11, 2021
Closed
@SherazJamil SherazJamil mentioned this issue Feb 1, 2022
Closed
@BulbulH BulbulH mentioned this issue Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes awaits Ascenio/Flutter-UIKit
3 participants
@Ascenio @Meherdeep @tadaspetra