Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ses)!: Remove evaluate endowments option #368

Merged
merged 4 commits into from Jul 13, 2020
Merged

fix(ses)!: Remove evaluate endowments option #368

merged 4 commits into from Jul 13, 2020

Conversation

kriskowal
Copy link
Member

Fixes #365

@kriskowal kriskowal requested review from warner and erights July 1, 2020 23:48
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch 2 times, most recently from 16defd8 to 81b45d4 Compare July 2, 2020 00:09
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch from 81b45d4 to 24fb986 Compare July 2, 2020 00:51
@kriskowal kriskowal mentioned this pull request Jul 2, 2020
Merged
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch 2 times, most recently from 96a3bbf to e2f50c5 Compare July 2, 2020 17:38
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch 2 times, most recently from 200bdbf to eaaa1f8 Compare July 3, 2020 00:08
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch 2 times, most recently from 21504bf to d17b93e Compare July 4, 2020 00:24
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch 2 times, most recently from 902ee99 to 211cbbc Compare July 4, 2020 00:52
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch from 211cbbc to 8e2e8a1 Compare July 4, 2020 00:53
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch 2 times, most recently from 259c5ea to 59dc2a4 Compare July 4, 2020 01:00
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch 2 times, most recently from 8a03c2f to e5ffc80 Compare July 4, 2020 01:17
Base automatically changed from kris/global-lexicals to master July 5, 2020 01:59
@kriskowal kriskowal force-pushed the kris/no-evaluate-endowments branch from e5ffc80 to 606d156 Compare July 5, 2020 04:35
erights
erights approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriskowal kriskowal merged commit e7b7b6e into master Jul 13, 2020
@kriskowal kriskowal deleted the kris/no-evaluate-endowments branch July 13, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights approved these changes

@warner warner Awaiting requested review from warner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planned breaking change: Remove compartment.evaluate endowments option
2 participants
@kriskowal @erights