Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop used voteCounter vats #9372

Open
Chris-Hibbert opened this issue May 15, 2024 · 1 comment
Open

Drop used voteCounter vats #9372

Chris-Hibbert opened this issue May 15, 2024 · 1 comment
Assignees
Labels
contract-upgrade enhancement New feature or request Governance Governance performance Performance related issues

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented May 15, 2024

What is the Problem Being Solved?

Each time the EC takes a vote on MainNet, a new voteCounter vat is created. the outcome of the vote isn't recorded anywhere, so the vats aren't deleted upon completion. Currently, 46 out of 123 vats on mainNet are voteCounters which have finished. They shouldn't ever be paged in, so they won't use up computrons, but it's space that has to be preserved.

Description of the Design

We want to make vote outcomes visible both on-chain and off-line.

VStorage will suffice for the off-line store. Committee have access to the outcome, and could start recording it, and could also make it accessible. Committees are not upgradeable, so we'd have to wait until we're willing to replace them.

Before terminating the existing vats, we would need to also write code to backfill the past questions and make their data available both on- and off-line.

Security Considerations

N/A

Scaling Considerations

yes.

Test Plan

verify that clients of the outcomes won't be harmed by cleaning up these vats.

Upgrade Considerations

yes.

@Chris-Hibbert
Copy link
Contributor Author

Later discussions clarified that

  • vstorage doesn't need to continue to store all the history. It's okay for some data to be retrievable from vstorage
  • "publisher updates that can be received off-chain should be receivable on-chain too." There's no need to make all info that was once available via notification perpetually available.

I think we can terminate old voteCounters whenever it's convenient.
@warner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request Governance Governance performance Performance related issues
Projects
None yet
Development

No branches or pull requests

1 participant