Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that start:contract results in an offerUp instance in agoricNames #46

Open
dckc opened this issue Jan 23, 2024 · 1 comment
Open

Comments

@dckc
Copy link
Member

dckc commented Jan 23, 2024

Deploying the contract is a bit fragile (e.g. #60). Changes like #61 could easily break it.
Let's have each change tested by the bots to make sure that deploying the contract isn't broken.

design sketch: using an a3p integration test a la cosgov

cc @0xpatrickdev

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Feb 3, 2024

Idea: keep this worked scoped to an a3p style test. It should include:

  1. Install Bundles
  2. CoreEval Proposal
  3. Verify Instance is in agoricNames.instance (agd.query)
  4. Submit agd.tx('swingset wallet-action ...') to buy an Item.

There seems like there could be overlap with thoughts here - the current .sh scripts we use could be node scripts which are easier to test (and our developer community to grok). (Much of the logic we need is already in @agoric/synthetic-chain/../commonUpgradeHelper.js)

Separately:

  1. chainStorageWatcher integration test to ensure instance, purses can be retrieved (would've caught the regression in fix: wallet connection and chainStorageWatcher #63, but not sufficient to test the walletConnection flow)
  2. E2E with Keplr using something like dappeteer (requires a keplr plugin to be built)

Edit: this is maybe want dan already means, outside of the increased scope suggestion to refactor /scripts/*, but "a la cosgov" currnetly just means queries against the 1317 endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants