Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardened js setup guide leads to broken eslint processes #588

Closed
tgrecojs opened this issue Dec 9, 2021 · 3 comments
Closed

hardened js setup guide leads to broken eslint processes #588

tgrecojs opened this issue Dec 9, 2021 · 3 comments
Assignees

Comments

@tgrecojs
Copy link
Contributor

tgrecojs commented Dec 9, 2021

Following the steps outlined in the "Hardened JavaScript" section of the docs results in eslint not working as it should. You can view this repository which has been created by following the steps outlined in the docs:

https://github.com/tgrecojs/jessie.js-eslint-repo

I can update this issue with steps for fixing this problem if it would be useful. it's my understanding that the missing links are one of (or a combination) of the following steps:

  • adding the "processor" property as outlined in jessie/packages/eslint-plugin.
  • installing the @typescript-eslint/parser package alongside @jessie.js/eslint-config
@tgrecojs tgrecojs changed the title hardened js setup guide with jessie.js/eslint-config hardened js setup guide leads to broken eslint processes Dec 9, 2021
@tgrecojs
Copy link
Contributor Author

tgrecojs commented Dec 9, 2021

tagging @dckc for exposure purposes

@dckc
Copy link
Member

dckc commented Dec 9, 2021

@michaelfig bonus points if you beat me to addressing this one.

@tgrecojs
Copy link
Contributor Author

tgrecojs commented Dec 9, 2021

just a heads up - pushed a fix branch that resolves the issue. not sure if it solves the root cause, but looks as though the eslintConfig.extends array is looking for a different reference of the jessie eslint plugin.

whereas i thought there might be a need for the typescript-parser package, it seemed to be as simple as changing the string from jessie to plugin:@jessie.js/recommended. didn't even need processor` property mentioned in endo/jessie.js repo 🙂

branch is here - fix branch the only change is the following tho:

  "eslintConfig" : {
      "extends": [
        "plugin:@jessie.js/recommended"
      ]
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants