Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crop_eos is for 13 crops too high #162

Closed
SvenVw opened this issue Feb 10, 2022 · 2 comments · Fixed by #172
Closed

crop_eos is for 13 crops too high #162

SvenVw opened this issue Feb 10, 2022 · 2 comments · Fixed by #172
Assignees
Labels
bug Something isn't working

Comments

@SvenVw
Copy link
Member

SvenVw commented Feb 10, 2022

For several crops the crop_eos in crops.obic is extremely high and probably not correct. This will result in inaccurate organic matter balances

image

@SvenVw SvenVw added the bug Something isn't working label Feb 10, 2022
@gerardhros
Copy link
Contributor

i asked brent to check and update. @BrentWHR , can you make a branch to fix this?

@BrentWHR
Copy link
Contributor

I'm pretty sure this has to do with perspotjes somehow. I found an older list with EOS values for this crops with and without perspotjes. The values with perspotjes are not integer Andijvie with perspotje for example: 2882.304 (barring the decimal seperator the same number as in the current list)
All other values without perspotjes are integer. I suspect the decimal seperator got lost somewhere either in conversions to and from csv, mixing up decimal seperators, or forcing integers somewhere.

I'm not sure to which brp crop the perspotjes belong and where we can best restore this.

@BrentWHR BrentWHR linked a pull request Oct 31, 2022 that will close this issue
@BrentWHR BrentWHR closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants