Yuki maatregelen #37
Merged
Yuki maatregelen #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Variables are nullified. |
SvenVw
approved these changes
Nov 29, 2019
Merged
gerardhros
reviewed
Dec 2, 2019
gerardhros
reviewed
Dec 2, 2019
R/obic_recommendations.R
Outdated
|
|
||
| # Merge soil and crop categories to dt.score --------------------------------------- | ||
| # Make an additional category for loess | ||
| soils.obic[soiltype == 'loess', soiltype.n := 'loess'] |
There was a problem hiding this comment.
is loess not already part of soils.obic? should be, isn't?
…Bodem-Index-Calculator into yuki_maatregelen
…Bodem-Index-Calculator into yuki_maatregelen
SvenVw
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A script to choose top 3 measures is added. The script includes 2 function: 'obic_evalmeasure' (to quantify effects of 11 measures) and 'obic_recommendations' (to choose top 3 measures). A table is also added in which expert-judgement of effects of measures are defined (maatregel_obic.Rdata).
To be solved: many temporal auxiliary variables are added as columns (and many of them are deleted within the script), making many warning messages. They need to be nullified (?) in the begining.
Comment Gerard, 3-12-19
i rewrote this function, more in a data.table style;
the former one makes multiple new columns while looping throught the measures and indices.
by using dcast and melt it makes the script simpler, easier to understand / test / evaluate.
and likely also faster.
one attention point: for some reason the measure.obic.Rdata is not recognized in namespace when checked.
Comment update