Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burrowed Swarm Hosts and Ravagers collide with burrowed Movers #12

Closed
Ahli opened this issue Dec 18, 2022 · 0 comments
Closed

Burrowed Swarm Hosts and Ravagers collide with burrowed Movers #12

Ahli opened this issue Dec 18, 2022 · 0 comments
Labels
fix available a proper fix for an issue impacts esport

Comments

@Ahli
Copy link
Owner

Ahli commented Dec 18, 2022

Most burrowed units have the collision with "Burrow".
Roach and Infestor can move while underground, so they have their own collision flag: "Roach Burrow".

Burrowed Swarm Hosts and Ravagers currently collide with both, "Burrow" and "Roach Burrow".
They are the only burrowed units with this combination.
=> They should probably only use "Burrow" as I cannot see what should make them special enough to collide with Roach/Infestor.

video

Test Map

Code to remove the collision, so they interact with Ravager and Swarm Hosts just like burrowed Ultralisks, Drones, Hydralisks, Queens, Zerglings, Banelings, Lurkers and Widow Mines:

    <CUnit id="RavagerBurrowed">
        <Collide index="RoachBurrow" value="0"/>
    </CUnit>
    <CUnit id="SwarmHostBurrowedMP">
        <Collide index="RoachBurrow" value="0"/>
    </CUnit>

Since the Roach only becomes a burrowed Mover with an upgrade, maybe the upgrade should switch the collision from Burrowed to RoachBurrow.
So, super accurate would be:

    <CUnit id="RoachBurrowed">
        <Collide index="Burrow" value="1"/>
        <Collide index="RoachBurrow" value="0"/>
    </CUnit>

    <CUpgrade id="TunnelingClaws">
        <EffectArray Operation="Set" Reference="Unit,RoachBurrowed,Collide[Land1]" Value="0"/>
        <EffectArray Operation="Set" Reference="Unit,RoachBurrowed,Collide[Land7]" Value="1"/>
    </CUpgrade>

bug report in Blizzard's forums

@Ahli Ahli added unfixed bug Something isn't working and there is no fix or workaround fix available a proper fix for an issue impacts esport and removed unfixed bug Something isn't working and there is no fix or workaround labels Dec 18, 2022
@Ahli Ahli changed the title Burrowed Swarm Hosts and Ravagers have inconsistent collision flags Burrowed Swarm Hosts and Ravagers collide with burrowed Movers Dec 19, 2022
@Ahli Ahli closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix available a proper fix for an issue impacts esport
Projects
None yet
Development

No branches or pull requests

1 participant