Water ripples and flying units/structures fixed/polished

[Ahli]

Issues

1. The Liberator does not create water ripples when flying above water at all. It lacks the settings for that. All other Terran flying buildings and units, and Protoss Mothership have settings for that.
2. The settings are not fine tuned, so some units show ripples and some show none depending on the height of the map's water

Fix

I split the fix into 2 parts, since I am not sure if the cliff edge fix impacts the performance. Since units are walking on the ground height level, I guess that the site operation will be fine as well.

1. Liberator has 4 actors which require the missing settings
2. I tweaked the height of the ripple generation range to match the units who were the lowest: Banshee and Raven

Actor Changes

    <CActorUnit id="Barracks">
        <TerrainSquibs index="0" RangeDown="5.800000"/>
    </CActorUnit>
    <CActorUnit id="Battlecruiser">
        <TerrainSquibs index="0" RangeDown="5.150000"/>
    </CActorUnit>
    <CActorUnit id="CommandCenter">
        <TerrainSquibs index="0" RangeDown="6.250000"/>
    </CActorUnit>
    <CActorUnit id="Factory">
        <TerrainSquibs index="0" RangeDown="6.200000"/>
    </CActorUnit>
    <CActorUnit id="Liberator">
        <Macros value="TerrainSquibAnimations"/>
        <TerrainSquibs>
            <MovementDistance value="0.150000,0.150000"/>
            <IdlePeriod value="0.250000,0.500000"/>
            <RangeDown value="4.950000"/>
            <RangeDownFade value="1.000000"/>
            <AttachQuery Methods="AMFilterCenter"/>
            <Visuals TerrainPhysicsMaterial="Water" ActorModel="TerrainSquibHarnessContinuous" ModelLink="WaterRippleMassive15"/>
        </TerrainSquibs>
    </CActorUnit>
    <CActorUnit id="LiberatorAG">
        <Macros value="TerrainSquibAnimations"/>
        <TerrainSquibs>
            <MovementDistance value="0.150000,0.150000"/>
            <IdlePeriod value="0.250000,0.500000"/>
            <RangeDown value="4.950000"/>
            <RangeDownFade value="1.000000"/>
            <AttachQuery Methods="AMFilterCenter"/>
            <Visuals TerrainPhysicsMaterial="Water" ActorModel="TerrainSquibHarnessContinuous" ModelLink="WaterRippleMassive15"/>
        </TerrainSquibs>
    </CActorUnit>
    <CActorUnit id="LiberatorAGMorphModel">
        <Macros value="TerrainSquibAnimations"/>
        <TerrainSquibs>
            <MovementDistance value="0.150000,0.150000"/>
            <IdlePeriod value="0.250000,0.500000"/>
            <RangeDown value="4.950000"/>
            <RangeDownFade value="1.000000"/>
            <AttachQuery Methods="AMFilterCenter"/>
            <Visuals TerrainPhysicsMaterial="Water" ActorModel="TerrainSquibHarnessContinuous" ModelLink="WaterRippleMassive15"/>
        </TerrainSquibs>
    </CActorUnit>
    <CActorUnit id="LiberatorMorphModel">
        <Macros value="TerrainSquibAnimations"/>
        <TerrainSquibs>
            <MovementDistance value="0.150000,0.150000"/>
            <IdlePeriod value="0.250000,0.500000"/>
            <RangeDown value="4.950000"/>
            <RangeDownFade value="1.000000"/>
            <AttachQuery Methods="AMFilterCenter"/>
            <Visuals TerrainPhysicsMaterial="Water" ActorModel="TerrainSquibHarnessContinuous" ModelLink="WaterRippleMassive15"/>
        </TerrainSquibs>
    </CActorUnit>
    <CActorUnit id="Medivac">
        <TerrainSquibs index="0" RangeDown="5.100000"/>
    </CActorUnit>
    <CActorUnit id="Mothership">
        <TerrainSquibs index="0" RangeDown="5.750000"/>
    </CActorUnit>
    <CActorUnit id="OrbitalCommand">
        <TerrainSquibs index="0" RangeDown="6.750000"/>
    </CActorUnit>
    <CActorUnit id="Starport">
        <TerrainSquibs index="0" RangeDown="6.250000"/>
    </CActorUnit>
    <CActorUnit id="VikingFighter">
        <TerrainSquibs index="0" RangeDown="5.050000"/>
    </CActorUnit>

Test Map

Test map

Remaining Issues

There does not seem to be a good way to spawn ripples only on the height of water. Currently, the ripples also spawn on top of cliff edges and that does not look great.

I had good results using the sync ground heightmap and ignore-if-no-water terrain flag in the site-ops' settings. But I need to explore that a bit more to make sure it is feasible and has no drawbacks. It did not look good in water puddles, so walkable ground with unsteady height and shallow water

bug report in Blizzard's forums