Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode #124

Closed
kevnm67 opened this issue Nov 25, 2018 · 5 comments
Closed

Support dark mode #124

kevnm67 opened this issue Nov 25, 2018 · 5 comments

Comments

@kevnm67
Copy link

kevnm67 commented Nov 25, 2018

Issue 馃毀

  • Checkbox text isn't visible when dark mode is enabled.
  • Mac Mojave with dark mode enabled

Current Behavior 馃攳

  • 'Constructor' and other checkbox text isn't visible.

Steps to Reproduce

  1. Run JsonExport using Mojave with dark mode enabled.

Screen shots

screen_shot_2018-11-25_at_3_14_40_pm

@PlutusCat
Copy link

You can edit this Main.storybiard
image
and recompile.
image

@huabin
Copy link
Collaborator

huabin commented Sep 6, 2019

@kevnm67 Hello, I have fixed this and submitted a PR to the developer, and you can use my version from https://github.com/hzb/JSONExport if you don't want to wait, or you can download the application from https://www.dropbox.com/s/20dm3241jdiwq7p/JSONExport.zip?dl=0, thank you.

@kevnm67
Copy link
Author

kevnm67 commented Sep 6, 2019

@hzb I'll check it out. Thanks!

@huabin
Copy link
Collaborator

huabin commented Sep 6, 2019

@kevnm67 You are welcome. BTW if it works well, please close this issue, if not, please append the error, I will fix.

@kevnm67
Copy link
Author

kevnm67 commented Sep 6, 2019

@hzb Just verified the change locally. Looks good. Thoughts on referencing this issue in your PR? (e.g. fixes #124). Github will automagically close this issue once your PR is closed/merged.

@huabin huabin closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants