Fix list encoding #4

Starmel · 2021-03-03T08:56:21Z

Problem:

In current version, encoding of top level List structure can't be decoded because don't contains size field.

Example:

// Exists items in adapter. 
val bundle = adapter.items.bundle(ListSerializer(Item.serializer()))

val items = state.unbundle(ListSerializer(Item.serializer()))
// items size = 0

Solution:

Moved adding size key to before keyInParent to fix issue. I don't sure what nothing was not broken by this change, please verify solution.

AhmedMourad0 · 2021-03-03T18:55:15Z

Thank you for filing this issue and PR, I'll be looking into it very shortly.

AhmedMourad0 · 2021-03-04T06:48:54Z

The fix is now available starting from v0.5.0 , Thank you for your contribution!

Update BundleEncoder.kt

d91c51c

AhmedMourad0 merged commit f7a75be into AhmedMourad0:master Mar 4, 2021

AhmedMourad0 added a commit that referenced this pull request Mar 4, 2021

Added tests for #4 lists and maps

e0a2df4

AhmedMourad0 added bug Something isn't working good first issue Good for newcomers labels Mar 4, 2021

AhmedMourad0 self-assigned this Mar 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix list encoding #4

Fix list encoding #4

Starmel commented Mar 3, 2021

AhmedMourad0 commented Mar 3, 2021 •

edited

AhmedMourad0 commented Mar 4, 2021

Fix list encoding #4

Fix list encoding #4

Conversation

Starmel commented Mar 3, 2021

Problem:

Example:

Solution:

AhmedMourad0 commented Mar 3, 2021 • edited

AhmedMourad0 commented Mar 4, 2021

AhmedMourad0 commented Mar 3, 2021 •

edited