[BUG] Outdated prior 'constant' set in em_sample.m

[reliable-nranganathan]

Description

When sampling a correlated model with em_sample.m, line 50 sets the prior to 'constant', which is not recognized by bn_dirichlet_prior.m, and results in a terminal exception "Unknown prior of constant, if char expecting prior = 'dbe'".

Reproducibility

Running
em_sample('cor_v2p1.txt')
should result in the exception.

Expectation

Changing line 50 in em_sample.m parms.prior = 'constant' to parms.prior='dbe' should resolve the issue and produce hte expected functionality.

Environment

Debian 10, MATLAB R2021a

[aweinert-MIT]

This bug was introduced when we first committed the OOP definitions for the EncounterModel superclass and UncorEncounterModel class (commit 8bb3572). This bug was not caught during testing for commit 8bb3572 because the default functionality in the EncounterModel class sets the prior to 0 and the CorTerminalModel class either sets the prior to 0 or via the setTransitionPriors function.

In commit 8bb3572, bn_dirichlet_prior was updated to look for 'dbe' instead of 'constant' because we felt 'dbe' was more descriptive than the generic term, 'constant'.

The recommended fix by @reliable-nranganathan should resolve this bug.