Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python exception on OSX - dark mode? #1

Closed
tristancollins opened this issue Jan 6, 2022 · 2 comments
Closed

Python exception on OSX - dark mode? #1

tristancollins opened this issue Jan 6, 2022 · 2 comments

Comments

@tristancollins
Copy link

I get the attached error when loading the PCB editor.

Kicad 6.0 on latest mac OSX

"AttributeError: 'PishForKiCadPlugin' object has no attribute 'dark_icon_file_name'"

Perhaps related to dark mode?
Aisler_error

The icon appears as a generic extension icon along the toolbar.

@tristancollins
Copy link
Author

tristancollins commented Jan 6, 2022

The search result from below indicate this may be a KiCAD issue?

https://gitlab.com/search?group_id=6593371&scope=blobs&search=dark_icon_file_name

If icon is not specified a generic tool icon will be used.

An additional property `self.dark_icon_file_name` may be specified to provide an alternate icon for
dark window themes.  If this property is not present, the icon specified in `icon_file_name` will
be used when the dark theme is active;

A fix would be to add the last two lines below to plugin.py at line 53:

        self.icon_file_name = os.path.join(
            os.path.dirname(__file__), 'icon.png')
        self.dark_icon_file_name = os.path.join(
            os.path.dirname(__file__), 'icon.png')

@PatrickFranken
Copy link
Member

Thanks for the report including the actual solution to this :) Will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants