Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable compression if Kafka is configured to compress log segments #129

Closed
1 task
mdedetrich opened this issue Mar 16, 2023 · 1 comment
Closed
1 task

Disable compression if Kafka is configured to compress log segments #129

mdedetrich opened this issue Mar 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mdedetrich
Copy link
Contributor

What is currently missing?

Currently with this plugin, compression is forcefully enabled even if it doesn't make sense in certain cases

How could this be improved?

The plugin should detect if Kafka has compression enabled for a specific topic and if so not to compress within the plugin. This can also help deal with the current ongoing issue in fetching specific byte ranges (see #127)

Is this a feature you would work on yourself?

  • I plan to open a pull request for this feature
@mdedetrich mdedetrich added the enhancement New feature or request label Mar 16, 2023
@jeqo
Copy link
Contributor

jeqo commented May 30, 2023

Implemented by #230

@jeqo jeqo closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdedetrich @jeqo