Map of Xaero's World Map gets reset when joining secure servers #156
Labels
3rd party issue
The issue is not related to this mod alone
bug
Something isn't working
confirmed
Confirmed bug/approved suggestion
low priority
Modloader
Forge
Minecraft Version
1.19.1
Modloader Version
Forge 43.0.8
No Chat Reports Version
1.19.2-v1.4.0
Modpack Info
No response
The latest.log File
https://pastebin.com/mWLAz0V2
Bug Description
When joining a server with
enforce-secure-profile=true
with Xaero's World Map and NCR, the previously uncovered world map will be reset. This gets undone when re-joining the server without NCR, in this instance the previous world map is accessible again. Looking into this, this is likely caused by Xaero's World Map not being able to query the IP adress of the server and thus not knowing in what folder the world map for that server is stored. The IP (and, in fact, all other data the client is supposed to know about the current server) doesn't get set properly when connecting to a server withenforce-secure-profile=true
with NCR due to it not passing the ServerData argument toConnectScreen#startConnecting
(see NoChatReportsClient#reconnectLastServer).Steps to Reproduce
enforce-secure-profile
property set to true.Other Information
Tested this with Xaero's World Map 1.26.2.
If you want to fix this, I'd propose either trying to access the
currentServer
field ofMinecraft
to parse it into the mentioned method (though I don't know whether that field is already reset when theDisconnectionScreen
is opened) or storing the server data alongside the server adress inServerSafetyState
.The text was updated successfully, but these errors were encountered: