Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Telemetry Data Button #322

Closed
StunfMC opened this issue Dec 7, 2022 · 3 comments
Closed

Remove the Telemetry Data Button #322

StunfMC opened this issue Dec 7, 2022 · 3 comments
Assignees
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request

Comments

@StunfMC
Copy link

StunfMC commented Dec 7, 2022

Idea

The Telemetry Button should be removed. It is not in use and serves no purpose with the mod installed.

Reasoning

The addition of the Telemetry Data button adds a new row for buttons on the menu. This shifts the placement of the Done button and can mess with players who are used to the positioning in 1.19.2 and below.

Other Information

Modloader
Fabric

Minecraft Version
1.19.3

Modloader Version
Fabric Loader 0.61.3

No Chat Reports Version
1.19.3

@StunfMC StunfMC added the enhancement New feature or request label Dec 7, 2022
@StunfMC StunfMC changed the title Remove Telemetry Data Button Remove the Telemetry Data Button Dec 7, 2022
@Madis0
Copy link
Collaborator

Madis0 commented Dec 7, 2022

Removing the button would conflict with the idea of #320, might mess with other mods' expectations (of where vanilla buttons are located) and the button currently shows the player, what the telemetry toggle actually protects users against. I do not support this idea.

(edited as I misunderstood the OP initially)

@StunfMC
Copy link
Author

StunfMC commented Dec 7, 2022

The Telemetry Data button is useless, and there is no reason in my eyes not to remove it. Having a toggle in the NCR config if you want to have it or not is the easiest solution.

@StunfMC
Copy link
Author

StunfMC commented Dec 9, 2022

Reopened as a chain issue with #154. See #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants