Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow servers to translate/alter the kick message for players without the mod #48

Closed
Doenerstyle opened this issue Jul 2, 2022 · 3 comments
Assignees
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request low priority

Comments

@Doenerstyle
Copy link
Contributor

I think some servers would appreciate a (serverside) config option to translate this message:

handler.disconnect(Component.literal("You do not have No Chat Reports, and this server is configured to require it on client!"));

My ideas would be to either add that message to the lang files and let the server choose which one to use or to allow them to configure a custom message through the config, like plugins often do, which offers far more customization.

You could also have one config option which can be used for both:
If it is, for example, set to "en_en", the default translation is used, if no lang file with that String was found (or the format is not xx_xx), the String itself will be the message. That'll only work as long as there aren't multiple serverside messages, of course.

This suggestion is based on #45.

@Aizistral Aizistral added the enhancement New feature or request label Jul 2, 2022
@Aizistral Aizistral self-assigned this Jul 2, 2022
@Aizistral Aizistral added the confirmed Confirmed bug/approved suggestion label Jul 2, 2022
@k9ur
Copy link

k9ur commented Jul 21, 2022

If it can be configured that joining the server requires installation of the mod, why is this a required feature?
They do operate differently, but ultimately achieve the same thing, unless I am missing something?

@LoganDark
Copy link
Contributor

Servers don't have localizations without LanguageHack which I haven't updated to 1.19 yet

@Doenerstyle
Copy link
Contributor Author

I see. The (serverside) config should still be a good and viable option, however.

@otta8634 Sorry, I missed your comment. I don't quite understand what you mean, afaik that message is shown to clients without NCR if the server does have NCR installed and requires clients to do so, too. So I'm not sure what you think is "achieving the same thing"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

4 participants