Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this library be linked? #13

Closed
lebedev opened this issue Aug 15, 2018 · 7 comments
Closed

Should this library be linked? #13

lebedev opened this issue Aug 15, 2018 · 7 comments

Comments

@lebedev
Copy link

lebedev commented Aug 15, 2018

There're ios and android folders in this repo, and this library links automatically if react-native link command is run. However, In my project it isn't linked, and... it works just fine? At least the subset of features that I use.

Can you describe for what functionality should this library be linked? Are these from the example, maybe?

@shukerullah
Copy link

This is very annoying whenever I run react-native link command, this library is linked.

@mCodex
Copy link

mCodex commented Sep 19, 2018

Yes, I think it should be linked. I'm currently using RN 0.57 and what I've done so far is: react-native link react-native-global-props and then I go to Xcode and then:

  • Click in my project
  • Go to Build Phases
  • Click in Link Binary With Libraries
  • Remove ReactNativeGlobalProps.app and ReactNativeGlobalProps.test (something like that)
    And build

@lebedev
Copy link
Author

lebedev commented Sep 19, 2018

@mCodex why linking and then removing? Wasn't it working before you linked it?

@maieonbrix
Copy link
Contributor

@Ajackster can we delete those folders ?

@Ajackster
Copy link
Owner

@maieonbrix Yeah, we can remove them. I think I made this project using the react-native init command which included a bunch of files that can be removed since this library is just a couple utility functions.

@maieonbrix
Copy link
Contributor

I am on it, will open a PR in the following hours

@Ajackster
Copy link
Owner

Awesome, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants