Support for empty strings

Ajaxy · Aug 30, 2018 · 12d0b79 · 12d0b79
1 parent 18e2d5b
commit 12d0b79
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -12,7 +12,7 @@ function castWithSchema(query, schema) {
 }
 
 function castProp(value, propertyDef) {
-  if (!value || !propertyDef) {
+  if (!propertyDef || value === undefined) {
     return value;
   }
 

diff --git a/tests/all.test.js b/tests/all.test.js
@@ -30,7 +30,11 @@ describe('All', () => {
       s: ['777', '7.77', 'invalid-number'],
       t: {}, // invalid array
       u: 'value', // missing schema type
-      v: 'value', // missing type
+      v: 'value', // missing type,
+      w: '',
+      x: '', // `NaN` with integer
+      y: '', // `0` with number
+      z: '', // `true` with boolean
     }, {
       type: 'object',
       properties: {
@@ -123,8 +127,20 @@ describe('All', () => {
             type: 'number',
           },
         },
-        u: {
+        u: {},
+        w: {
+          type: 'string',
+        },
+        x: {
+          type: 'integer',
+        },
+        y: {
+          type: 'number',
+        },
+        z: {
+          type: 'boolean',
         },
+
       },
     })).toEqual({
       a: 'value',
@@ -155,6 +171,10 @@ describe('All', () => {
       t: undefined,
       u: 'value',
       v: 'value',
+      w: '',
+      x: NaN,
+      y: 0,
+      z: true,
     });
   });
 });