Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in directive tooltip bind hook: "TypeError: classList.indexOf is not a function" #67

Closed
mickeyklai opened this issue Nov 16, 2017 · 0 comments

Comments

@mickeyklai
Copy link

TypeError: classList.indexOf is not a function
at eval (v-tooltip.esm.js?455e:2456)
at Array.forEach ()
at addClasses (v-tooltip.esm.js?455e:2455)
at createTooltip (v-tooltip.esm.js?455e:3382)
at bind (v-tooltip.esm.js?455e:3414)
at callHook$1 (vue.esm.js?65d7:5855)
at _update (vue.esm.js?65d7:5780)
at Array.updateDirectives (vue.esm.js?65d7:5761)
at invokeCreateHooks (vue.esm.js?65d7:5299)
at createElm (vue.esm.js?65d7:5190)

v-tooltip version: v-tooltip@2.0.0-rc.20

The element in which it fails in the function addClasses is svg. ie: (el = svg, classList = SVGAnimatedString)

function addClasses(el, classes) {
var newClasses = convertToArray(classes);
var classList = convertToArray(el.className);
newClasses.forEach(function (newClass) {
if (classList.indexOf(newClass) === -1) {
classList.push(newClass);
}
});
el.className = classList.join(' ');
}

I made the following changes here and in the removeClasses function for it to work properly:

function addClasses(el, classes) {
var newClasses = convertToArray(classes);
var classList = convertToArray(el.className);
if (classList instanceof SVGAnimatedString)
classList = Array.from(classList);
newClasses.forEach(function (newClass) {
if (classList.indexOf(newClass) === -1) {
classList.push(newClass);
}
});
if (el instanceof SVGElement)
el.setAttribute('class', classList.join(' '));
else
el.className = classList.join(' ');
}

Thanks

@Akryum Akryum closed this as completed in 7c5d9ec Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant