Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resize story responsive preview #181

Merged
merged 2 commits into from Aug 1, 2022
Merged

fix: resize story responsive preview #181

merged 2 commits into from Aug 1, 2022

Conversation

arpansaha13
Copy link
Contributor

Description

When the responsive preview is at 'Auto' width and height, if we try to resize again, the preview immediately snaps to minimum width or height. After the snap value.value becomes null. During the next resize, the startValue takes up this null. I guess this is why it is happening.

Now when the snap happens, the resize placeholder shows 'Auto'. And in the next resize, the startValue is taken with respect to the current width/height.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jul 17, 2022

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit 9369db0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/62e7f2521933b300088ef44c

@netlify
Copy link

netlify bot commented Jul 17, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 9369db0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/62e7f2520f5cde00085b3024
😎 Deploy Preview https://deploy-preview-181--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 17, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 9369db0
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/62e7f252e77e6b0008a34847
😎 Deploy Preview https://deploy-preview-181--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@arpansaha13 arpansaha13 changed the title Fix resize preview fix: resize preview Jul 17, 2022
@arpansaha13 arpansaha13 changed the title fix: resize preview fix: resize story responsive preview Jul 17, 2022
@Akryum Akryum merged commit 0999c54 into histoire-dev:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants