Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histoire build fails with Vite base directory override (regression at 0.8.1 ➡️ 0.8.2) #219

Closed
6 tasks done
cyberbobs opened this issue Aug 1, 2022 · 0 comments
Closed
6 tasks done
Assignees
Labels
bug Something isn't working

Comments

@cyberbobs
Copy link

Describe the bug

histoire build fails if you try to redefine base directory in Histoire config file:

import { defineConfig } from 'histoire';

export default defineConfig({
  setupFile: '/src/histoire.setup.js',
  vite: {
    base: '/histoire-kit/',
  },
});

This is a regression between 0.8.1 ➡️ 0.8.2, and is still reproducible in 0.9.0.

Reproduction

https://stackblitz.com/edit/node-a7kwmr?file=.histoire.js

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04.4 LTS (Focal Fossa)
    CPU: (16) x64 AMD Ryzen 7 2700X Eight-Core Processor
    Memory: 22.58 GB / 31.28 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.16.0 - /usr/bin/node
    Yarn: 1.22.19 - ~/.npm-packages/bin/yarn
    npm: 8.13.2 - ~/.npm-packages/bin/npm
  Browsers:
    Chrome: 103.0.5060.134
    Firefox: 103.0
  npmPackages:
    @vitejs/plugin-vue: ^2.3.3 => 2.3.3 
    histoire: ^0.8.2 => 0.8.4 
    vite: ^2.9.14 => 2.9.14

Used Package Manager

yarn

Validations

@cyberbobs cyberbobs added the to triage This issue needs to be triaged label Aug 1, 2022
@Akryum Akryum added bug Something isn't working and removed to triage This issue needs to be triaged labels Aug 2, 2022
@Akryum Akryum self-assigned this Aug 2, 2022
@Akryum Akryum closed this as completed in 6cca1e1 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants