Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR not working on Windows #436

Closed
cannap opened this issue Feb 6, 2023 · 1 comment
Closed

HMR not working on Windows #436

cannap opened this issue Feb 6, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cannap
Copy link

cannap commented Feb 6, 2023

Describe the bug

aXUGzlWWx4

Reproduction

it works on Stackblitz so i cannot reproduce it its a fresh install with the newset 0.13 version

vite config

import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
import path from 'node:path'
import dts from 'vite-plugin-dts'
// https://vitejs.dev/config/
export default defineConfig({
  build: {
    lib: {
      entry: path.resolve(__dirname, 'src/components/index.ts'),
      name: 'ui',
      fileName: (format) => `ui.${format}.js`,
    },
    rollupOptions: {
      external: ['vue'],
      output: {
        // Provide global variables to use in the UMD build
        globals: {
          // Add external deps here

          vue: 'Vue',
        },
      },
    },
  },
  plugins: [dts({ outputDir: 'dist/types', include: 'src/components/**' }), vue()],
});

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (6) x64 Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz
    Memory: 3.64 GB / 15.94 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.5.0 - C:\Program Files\nodejs\npm.CMD
    pnpm( envinfo did not read) 7.24.3
  Browsers:
    Edge: Spartan (44.22621.1194.0), Chromium (109.0.1518.61)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @histoire/plugin-vue: ^0.13.0 => 0.13.0
    @vitejs/plugin-vue: ^4.0.0 => 4.0.0
    histoire: ^0.13.0 => 0.13.0
    vite: ^4.1.1 => 4.1.1


### Used Package Manager

pnpm

### Validations

- [X] Follow our [Code of Conduct](https://github.com/histoire-dev/histoire/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/histoire-dev/histoire/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://histoire.dev/guide/).
- [X] Check that there isn't [already an issue](https://github.com/histoire-dev/histoire/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/histoire-dev/histoire/discussions).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.
@cannap cannap added the to triage This issue needs to be triaged label Feb 6, 2023
@cannap
Copy link
Author

cannap commented Feb 7, 2023

i also testet it with the nuxt plugin same

@Akryum Akryum added bug Something isn't working and removed to triage This issue needs to be triaged labels Feb 8, 2023
@Akryum Akryum self-assigned this Feb 8, 2023
@Akryum Akryum closed this as completed in 2d5b3c8 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants