fix: restore scroll in keep-alive #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mark |
| const lastPosition = this.$_lastUpdateScrollPosition; | ||
| if (typeof lastPosition === 'number') { | ||
| this.$nextTick(() => { | ||
| this.scrollToPosition(lastPosition); |
There was a problem hiding this comment.
Does this have to be nextTick? The DOM should be ready by the time activated is called.
There was a problem hiding this comment.
It has been a long time. i do not remember very clearly. May be it is because when (positionDiff < itemSize) in updateVisibleItems method, something goes wrong with view calculated, So i make it asynchronous
Akryum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we use router-view and keep alive with RecycleScroller, if we change the router, then back, we will see the scroller position will change to the top. we need to keep the position