Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation of Ascension Levels Doesn't Work with Spontaneous Edifice #175

Closed
sugarfrosted opened this issue Apr 9, 2018 · 6 comments
Closed
Assignees
Labels

Comments

@sugarfrosted
Copy link

The number of levels granted doesn't take into account if buildings being sold would increase "Cookies in bank" to over "Cookies Baked (this ascension)", which would thus increase "Cookies Baked" to what "Cookies in Bank" would be.

@Aktanusa
Copy link
Collaborator

Aktanusa commented Apr 9, 2018

Hmm, if I understand you correctly, do you mean that buildings you got for free with Spontaneous Edifice does add to the total cookies Baked on selling, and because of that,the reset bonus stat is incorrect due to some achievements that can be gotten from the extra total cookies baked?

Edit: Nope, I think you mean selling of free buildings from Spontaneous Edifice would give more ascension levels and HC as well as the achievement bonus and reset bonus. It's all a messed! Yea, this is prob a bug.

@sugarfrosted
Copy link
Author

sugarfrosted commented Apr 10, 2018

It can add to the total cookies baked and this does throw off the computation. This seems to be because the way it seems to work is as follows: Letting total be the "total number of cookies baked (this ascension)" and bank be the total cookies in your bank it does the following:

if total < bank:
    total = bank

So, if you sell everything and this exceeds your total cookies baked it exceeds it. I was thinking just letting CE being the maximum computed amount of cookies from the chocolate egg, and letting Current be the current computation, taking max(Current,CE*21) or max(Current,CE*20), depending on whether or not the chocolate egg has been sold, to be used in computing chips should work.

This was never an issue before because outside of cheating total >= bank would always hold.

@Aktanusa
Copy link
Collaborator

Aktanusa commented Apr 24, 2018

I would need to look more into this as right now I'm still not getting you. Probably my reading comprehension is failing me right now, lol. I'll reread it a few times and get back.

@Aktanusa
Copy link
Collaborator

Okay, now that I have carefully reread it, I understand. That does sound like a bug. I need to find in CC code where this is happening.

@Aktanusa Aktanusa self-assigned this Apr 25, 2018
@Aktanusa Aktanusa added the Bug label Apr 25, 2018
@Aktanusa
Copy link
Collaborator

Aktanusa commented Apr 25, 2018

Found the line:

Game.cookiesEarned=Math.max(Game.cookies,Game.cookiesEarned);

Aktanusa added a commit that referenced this issue Apr 25, 2018
@Aktanusa
Copy link
Collaborator

Aktanusa commented Apr 25, 2018

Fixed in Version 2.0109.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants