Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aur-chroot: add --create #781

Merged
merged 2 commits into from Nov 6, 2020
Merged

aur-chroot: add --create #781

merged 2 commits into from Nov 6, 2020

Conversation

AladW
Copy link
Member

@AladW AladW commented Nov 2, 2020

Yet another rewrite of aur-chroot...

  • Set the default pacman.conf for aur-build --chroot to /etc/aurutils/pacman-<db>.conf. To accommodate this, the Makefile creates $(PREFIX)/etc/aurutils. Users will no longer have to write their config in /usr/share and can use a pacman.conf per local repository with no additional effort (apart from specifying the repository with -d or AUR_REPO).

  • Create containers with aur chroot --create, and allow to specify the target packages on the command-line. This way all required packages can be specified in one step, e.g. to include ccache in the container. This additional step is only required when using aur chroot directly, or if other packages than base-devel or multilib-devel are required; aur build runs aur chroot --create on each --chroot build. (This is possible because aur-chroot only runs mkarchroot if there is no existing container in the target path, which still defaults to /var/lib/aurbuild/<arch>.)

@AladW AladW added this to the 3.1.0 milestone Nov 2, 2020
Copy link
Member

@maximbaz maximbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides these comments, seems to work well 👍 Prepare to confuse people yet again about the config being now in a different location 😁

lib/aur-chroot Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
This does not require users to write files to /usr/share and allows to
have several pacman.conf files with --chroot (per repository) without
requiring --pacman-conf.
* Add --create which solely runs mkarchroot (and creation of parent
  directories). Compared to --update, this allows the user to specify
  the installed package(s) (groups) directly on the command-line

* If no packages are specified after --create, default to base-devel or
  multilib-devel depending if the pacman configuration (--pacman-conf)
  has a [multilib] section. This is done with pacini (instead of pacconf)
  due to devtools not supporting Include directives.

* When running --update, add a directory check and reminder to run
  aur-chroot --create.

* Add wait $! after pacman-conf to preserve the exit status.

* Let --packagelist read the makepkg.conf inside the container
  (depending on its directory), rather than a fixed path to makepkg.conf
  on the host.
@AladW
Copy link
Member Author

AladW commented Nov 6, 2020

Thanks! I'll update the blog post and post_install...

@AladW AladW merged commit 5b4b12d into master Nov 6, 2020
@AladW AladW deleted the chroot-etc branch November 6, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants