Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous Request Creation #2226

Closed
jshier opened this issue Aug 7, 2017 · 1 comment
Closed

Asynchronous Request Creation #2226

jshier opened this issue Aug 7, 2017 · 1 comment

Comments

@jshier
Copy link
Contributor

jshier commented Aug 7, 2017

Perhaps the most inelegant bit of Alamofire's current API is the handling of multipart form uploads. Due to the asynchronous nature of the request creation, it doesn't support chaining like every other Request API, requiring users to get the actual upload request in the completion for the request creation. Alamofire should move to an asynchronous Request creation model for all request types. Not only could this greatly simplify multipart uploads, but would allow expensive operations in other requests as well, an issue we've had reported before. Most likely this will entail something like a Future API for Request, or at least an internal state machine so that method chaining can still work.

@jshier jshier added this to the 5.0.0 milestone Aug 7, 2017
@jshier jshier added this to Idea in Alamofire 5 Aug 7, 2017
@jshier jshier moved this from Idea to Design in Alamofire 5 Oct 30, 2017
@jshier jshier moved this from Design to Review in Alamofire 5 May 21, 2018
@jshier jshier mentioned this issue May 21, 2018
4 tasks
@jshier jshier moved this from Review to Done in Alamofire 5 Sep 6, 2018
@jshier
Copy link
Contributor Author

jshier commented Sep 6, 2018

This was implemented in the rewrite.

@jshier jshier closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Alamofire 5
  
Done
Development

No branches or pull requests

1 participant