Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appstore submission rejected because of Alamofire inclusion?? #2551

Closed
ekscrypto opened this issue Jul 4, 2018 · 10 comments
Closed

Appstore submission rejected because of Alamofire inclusion?? #2551

ekscrypto opened this issue Jul 4, 2018 · 10 comments
Assignees

Comments

@ekscrypto
Copy link

ekscrypto commented Jul 4, 2018

screenshot 2018-07-04 15 59 45

ERROR ITMS-90171: "Invalid Bundle Structure - The binary file 'Magnet.app/Frameworks/Alamofire.framework/Alamofire' is not permitted. Your app can't contain standalone executables or libraries, other than a valid CFBundleExecutable of supported bundles. Refer to the Bundle Programming Guide at https://developer.apple.com/go??id=bundle-structure for information on the iOS app bundle structure."

  1 platform :ios, '10.0'
  2 use_frameworks!
  3 
  4 target 'Magnet' do
  5     inherit! :search_paths
  6     pod 'Alamofire', '~> 4.6.0'
  7     pod 'AlamofireNetworkActivityLogger', '~> 2.2.0'
  8     pod 'CocoaLumberjack', '~> 3.4.1'
  9     pod 'Firebase/Core'
 10     pod 'Firebase/Performance'
 11     pod 'Gestalt', '~> 1.0.1'
 12     pod 'IHKeyboardAvoiding', '~> 4.2'
 13     pod 'NextGrowingTextView', '~> 1.2.2'
 14     pod 'SimpleImageViewer', '~> 1.1.1'
 15     pod 'SnapKit', '~> 4.0.0'
 16     pod 'SwiftLint', '~> 0.24.2'
 17     pod 'SwipeCellKit', '~> 2.0.1'
 18     pod 'YapDatabase', '~> 3.0.2'
 19     pod "youtube-ios-player-helper", "~> 0.1.4"
 20 end

The app is working fine when pushed via Crashlytics, runs fine locally on the device. I use Xcode to create the archive, sign it using the App Store distribution provisioning profile, but it fails when trying to upload it to iTunes with the error above; Alamofire being specifically named.

Please advise.

@kenstir
Copy link

kenstir commented Jul 4, 2018

I suggest you read https://github.com/Alamofire/Alamofire/blob/master/CONTRIBUTING.md then ask your question on Stack Overflow. If we all respect the authors' wishes regarding support tickets, they will have more time to devote to making the library better.

@ekscrypto
Copy link
Author

Thanks for the pointer @kenstir; as that section points out, Stack Overflow should be used for questions not directly related to the project; this one seems pretty bang on. Plus typically Stack Overflow isn't really fond of non-programming questions either.

@kenstir
Copy link

kenstir commented Jul 4, 2018

@ekscrypto I suspect the problem is not in Alamofire, but somewhere in your packaging. I have an app that passed Beta review (in TestFlight), and it packages Alamofire. I use Carthage, and I added the framework, then a custom build step calling carthage copy-frameworks.

@ekscrypto
Copy link
Author

Its strange, never had an issue packaging Alamofire in any of my apps using CocoaPods before, been using it as my go-to library for years now. I hope Apple didn't add a new "validation" rule..

@jshier
Copy link
Contributor

jshier commented Jul 4, 2018

I can assure you this has nothing to do with Alamofire, we just pop up in a lot of these errors since we're the first framework alphabetically. I would suggest checking to make sure you aren't copying your pod frameworks into your app at all, as that seems to be the most common cause I found while Googling.

@itsdamslife
Copy link

Hey @ekscrypto Did you try removing AlamoFire from pod and run a pod install so that Alamofire is removed from project.

Now try adding the pod again and run pod install. This will rule out any config issues while embedding the pod file.

@ekscrypto
Copy link
Author

ekscrypto commented Jul 6, 2018

@itsdamslife Just finished stripping out all traces of Alamofire (just commenting out all import Alamofire (and associated code) and commenting the lines in the Podfile), the app was successfully uploaded to iTunes. So whatever the issue is seems to be related to Alamofire particularly. I also tried re-adding Alamofire Pod then archiving, causes the following upload to iTunes to be rejected with the same error again.

@jshier
Copy link
Contributor

jshier commented Jul 7, 2018

@ekscrypto I was able to successfully submit an app using Alamofire and CocoaPods, so I'd guess you're probably hitting some sort of iTunes Connect bug. I suggest you contact them about it and let us know if there really something we need to do.

@jshier jshier self-assigned this Jul 7, 2018
@ekscrypto
Copy link
Author

@jshier I'll close this up; maybe someone can find the time to pursue this with Apple if they hit the same issue; due to this app release timing and Apple's usually slow replies I had to replace all networking code with native API instead. Hopefully this was just a fluke.

@jshier
Copy link
Contributor

jshier commented Jul 9, 2018

Another option would be to try building everything as static libraries instead of frameworks if you're using CocoaPods 1.5 or later. Just remove the use_frameworks! line from your Podfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants