New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider public access #43
Comments
Unit tests work just fine as-is. Are you running into any specific issue with access control? |
I'm not sure how your unit tests are set up – on my project, I have the Alamofire.swift file included in my framework target, which is linked against for the unit testing target. In my framework target, I was able to access the It's kind of an edge case, anyway, since I don't expect many people need Alamofire in their unit tests (I was just performing a sanity check when I ran into this problem). A possible solution would be including the Alamofire file in the unit test target, too. |
I would include all framework sources in the tests target instead of linking a test target against a framework. This way you can still access the internal members of the, would be, framework. |
As of 9f7c365, Alamofire is structured for use as a framework, rather than a drop-in file. The access control is such that the unit tests target in the provided test harness is able to successfully run all of the tests. |
Right now, Alamofire uses the default access control qualifier, internal. Other targets in a project, such a unit tests, might want to access these internal classes, too (to make requests, for instance). I'm a bit unsure which classes, extensions, and functions should be public and which ones left internal.
Related to #42.
The text was updated successfully, but these errors were encountered: