Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ship es6 token variables #11

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

znewton
Copy link
Contributor

@znewton znewton commented Aug 30, 2019

Alaska Airlines Pull Request

Summary:

When consuming design tokens within a modern JS project, it's nice to have access to the variables using ES6 modules.

To facilitate this, I added the javascript/es6 format to the JS transform group in the styleDisctionary config.

Also, I ran npm audit fix to fix 185 dependency vulnerabilities and added package-lock.json to the release git files so that the package version bump is version controlled in the lock file.

Type of change:

  • New capability
  • Revision of an existing capability

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you for your submission!

-- Orion Design System Team

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Zachary Newton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@blackfalcon
Copy link
Member

As a part of this update, we need to correct/update the docs that point to these files.
https://github.com/AlaskaAirlines/OrionDesignTokens#install-pre-processed-resources

The table has the incorrect name, that's my bad. Then we should add the new file you just created.

We should probably have better descriptions as to why one would use these files. I can take that on post if you want.

@blackfalcon
Copy link
Member

Post this update, the use of the color variable JS file will be reviewed and possibly deprecated from use.

@blackfalcon blackfalcon merged commit a98e2b4 into AlaskaAirlines:master Sep 3, 2019
AuroDesignSystem pushed a commit that referenced this pull request Sep 3, 2019
# [2.7.0](v2.6.0...v2.7.0) (2019-09-03)

### Features

* ship es6 token variables ([#11](#11)) ([a98e2b4](a98e2b4))
@AuroDesignSystem
Copy link
Collaborator

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants