Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic color token names #225

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Mar 15, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #223

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Add tier 3 tokens in place of hardcoded values or incorrectly used tier 2 tokens

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification

  • Color UI look the same as it does on docsite
  • All border UI styles use correct color
  • Icon colors look correct in all states
  • Background colors look correct in all states
  • Helptext colors look correct in all states
  • Tier 3 tokens are correctly named
  • Tier 3 tokens are pointing to correct tier 2 tokens in tokens.scss file

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Mar 15, 2024
@jordanjones243 jordanjones243 linked an issue Mar 15, 2024 that may be closed by this pull request
2 tasks
@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#223 branch 2 times, most recently from e36c223 to 3a8c701 Compare June 3, 2024 18:24
@jordanjones243
Copy link
Contributor Author

A linting error comes up in this repo and needs to be addressed before releasing this work:

@jordanjones243 jordanjones243 marked this pull request as ready for review June 3, 2024 18:25
@jordanjones243 jordanjones243 requested a review from a team as a code owner June 3, 2024 18:25
@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#223 branch 2 times, most recently from d1407cc to 03fb521 Compare June 14, 2024 19:25
@jordanjones243
Copy link
Contributor Author

jordanjones243 commented Jun 14, 2024

Something to point out: there is a token here for onDark styles that is called ds-state-error-100, but that token is now deprecated. There is no replacement currently.

@jordanjones243 jordanjones243 changed the base branch from main to beta June 20, 2024 18:51
src/tokens.scss Outdated Show resolved Hide resolved
src/tokens.scss Outdated Show resolved Hide resolved
src/tokens.scss Show resolved Hide resolved
src/tokens.scss Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#223 branch 3 times, most recently from 2c0fa2d to 834930a Compare June 24, 2024 18:52
src/color.scss Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit b16fe03 into beta Jun 24, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/updateTokenNames/#223 branch June 24, 2024 22:28
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
3 participants