Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-flightline: Remove bottom padding from stops #69

Closed
ArcherScript opened this issue Apr 22, 2024 · 4 comments
Closed

auro-flightline: Remove bottom padding from stops #69

ArcherScript opened this issue Apr 22, 2024 · 4 comments
Assignees
Labels
auro-flightline not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@ArcherScript
Copy link

ArcherScript commented Apr 22, 2024

Is your feature request related to a problem? Please describe.

I don't feel like stops should have their bottom padding baked into the component. I think it may look nice when you see it in the documentation WITH the bottom-padding, but not every container is going to be the same. See the screenshots attached.

image image

The container has built in padding, which does not take into account the bottom padding from the stop's IATA.

Describe the solution you'd like

Remove the bottom padding from the stop's IATA code.

Describe alternatives you've considered

Allow us to customize the CSS for stops

Additional context

Stop's IATA code is located within the shadow dom so they are unmodifiable.

@ArcherScript ArcherScript added auro-flightline not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Apr 22, 2024
@blackfalcon
Copy link
Member

blackfalcon commented Apr 22, 2024

@ArcherScript I do not believe what you are referencing is an Auro component. That is is not 100% consistent with the Auro Flightline component seen here.

Here is a screenshot of the flightline element, its HTML and applied styles.

Screenshot 2024-04-22 at 11 43 52 AM Screenshot 2024-04-22 at 11 46 08 AM Screenshot 2024-04-22 at 11 45 18 AM



I do agree that an element should NOT have any influence outside the context of the element itself, but as you can see flightline is not adding that space.

Can you tell us more about the context of this UI so that we can assist with resolution?

@ArcherScript
Copy link
Author

ArcherScript commented Apr 22, 2024

@ArcherScript I do not believe what you are referencing is an Auro component. That is is not 100% consistent with the Auro Flightline component seen here.

Here is a screenshot of the flightline element, its HTML and applied styles.

Screenshot 2024-04-22 at 11 43 52 AM Screenshot 2024-04-22 at 11 46 08 AM Screenshot 2024-04-22 at 11 45 18 AM
I do agree that an element should NOT have any influence outside the context of the element itself, but as you can see flightline is not adding that space.

Can you tell us more about the context of this UI so that we can assist with resolution?

In the screenshot provided the stop has a datetime applied to it. In the screenshot below you will see bottom padding added to the IATA.

image

This screenshot is directly from the auro-flight documentation. https://auro.alaskaair.com/components/auro/flight#:~:text=auro%2Dflight%3E-,Mainline%20multi%2Dstop,-The%20following%20example

Manage team has been working with the flightline and flight component and have noticed a few design issues when the component does not have dates or times applied to it. Maybe it's related to that?

@blackfalcon
Copy link
Member

blackfalcon commented Apr 22, 2024

@ArcherScript this screenshot is very different from the initial one you initially referenced. I would suggest scheduling a meeting with an Auro engineer @jordanjones243 and our designer @michelle-alaskaair to review this issue so that we can better understand and look for a path forward. Please feel free to include your team's designer as well.

@ArcherScript
Copy link
Author

I still would like bottom padding removed from a stop's IATA code, or at least allow us to customize styles. Manage's design team has reached out and has reached a conclusion. We have a path forward now, feel free to close this issue.

@Patrick-Daly-AA Patrick-Daly-AA closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-flightline not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Development

No branches or pull requests

3 participants