Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at implementing the addition requested in issue #99. #103

Closed
wants to merge 5 commits into from

Conversation

Lovasz-Akos
Copy link

@Lovasz-Akos Lovasz-Akos commented Jul 24, 2022

Couldn't test full release build since I don't have the keystore for it (hopefully when this pr opens github actions run to see if it builds?)

#99 wanted the ability to delete all of the done items in multi list mode aswell, since right now this feature is only availible on single list mode.

Lovasz-Akos and others added 4 commits July 24, 2022 17:30
as requested issue Albert221#99, added options to "undone all done" and "remove all done" to the multiple list mode aswell
.1.1 throws error Running Gradle task 'assembleDebug'...                             61.1s
Exception: Unsupported Android Plugin version: 4.1.1.
@Lovasz-Akos Lovasz-Akos changed the title Attempt at implementing the addition requested in #99. Attempt at implementing the addition requested in issue#99. Jul 24, 2022
@Lovasz-Akos Lovasz-Akos changed the title Attempt at implementing the addition requested in issue#99. Attempt at implementing the addition requested in issue #99. Jul 24, 2022
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Base: 97.32% // Head: 97.32% // No change to project coverage 👍

Coverage data is based on head (207f503) compared to base (c50abc2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files           6        6           
  Lines         187      187           
=======================================
  Hits          182      182           
  Misses          5        5           
Flag Coverage Δ
bloc 97.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lovasz-Akos
Copy link
Author

some extra info on kotlin and gradle version updates:

@Lovasz-Akos
Copy link
Author

Lovasz-Akos commented Jul 24, 2022

using gradle 4.1.1 failed with the following message, so downgraded to 4.1.0, a fix suggested here

Running Gradle task 'assembleDebug'...
Exception: Unsupported Android Plugin version: 4.1.1.

@Lovasz-Akos
Copy link
Author

targeted sdk had to be raised to fix a dependency conflict that needs a higher sdk. fails with the following

Execution failed for task ':app:checkFossDebugAarMetadata'.
> Multiple task action failures occurred:
   > A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
      > The minCompileSdk (31) specified in a
        dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
        is greater than this module's compileSdkVersion (android-29).
        Dependency: androidx.window:window-java:1.0.0-beta04.
        AAR metadata file: C:\Users\akos4\.gradle\caches\transforms-2\files-2.1\68fac80a543730b86add500257caced4\jetified-window-java-1.0.0-beta04\META-INF\com\android\build\gradle\[aar-metadata.properties](http://aar-metadata.properties/).

@Lovasz-Akos
Copy link
Author

flutter version had to be raised because of the following build fail

BUILD FAILED in 19s
Running Gradle task 'assembleDebug'...                             20.3s

┌─ Flutter Fix ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ [!] Your project requires a newer version of the Kotlin Gradle plugin.                                                                          │
│ Find the latest version on https://kotlinlang.org/docs/gradle.html#plugin-and-versions, then update D:\Repos\FastShopping\android\build.gradle: │
│ ext.kotlin_version = '<latest-version>'                                                                                                         │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
Exception: Gradle task assembleDebug failed with exit code 1

@Lovasz-Akos
Copy link
Author

also the logo turned orange and I have no idea why

@Lovasz-Akos Lovasz-Akos closed this Jun 6, 2023
@Lovasz-Akos
Copy link
Author

well this app is sadly dead, imma make my own lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant