Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Pop up / modal does not load form content / displayed empty #1953

Closed
ck2000 opened this issue Oct 24, 2020 · 6 comments · Fixed by #1961
Closed

Admin: Pop up / modal does not load form content / displayed empty #1953

ck2000 opened this issue Oct 24, 2020 · 6 comments · Fixed by #1961

Comments

@ck2000
Copy link

ck2000 commented Oct 24, 2020

Steps to reproduce

On the following pages the modal / pop up does not load the form. The modal has not content / is rendered emtpy.

  • node / new
  • page / edit the page properties

Expected behavior

  • Show the form input fields on the new node page.
  • Show the form input fields on the edit page properties.

Actual behavior

Adding a sub node / menu item shows an empty modal form.
Editing a page show the form of

System configuration

  • Alchemy Version: latest 5.1.alpha
  • Rails Version: 6.0.3.4
@tvdeyen
Copy link
Member

tvdeyen commented Nov 8, 2020

You need to install the @alchemy_cms/admin npm module with

yarn add @alchemy_cms/admin

@tvdeyen
Copy link
Member

tvdeyen commented Nov 11, 2020

Plus my project is using select2 version 4. Alchemy currently requires version 3. I had to get to versions of select2:

Adding version3:
yarn add select2-v3@npm:select2@3

import the package app/javascript/packs/admin/admin.js
import "select2-v3/select2"

You should not need to do that. Alchemy already ships with the correct version of select2 v3

See https://github.com/AlchemyCMS/alchemy_cms/blob/main/alchemy_cms.gemspec#L40

Not sure why it is not working for you. How did you added your version of select2 v4? It should not be loaded in the Alchemy admin, so I am not sure why it is conflicting with your version of it. Have you added it to the Alchemy admin JS?

@tvdeyen
Copy link
Member

tvdeyen commented Nov 11, 2020

@ck2000 should hopefully fixed by #1961 could you try?

# Gemfile
gem "alchemy_cms", github: "tvdeyen/alchemy_cms", branch: "select2-v3-asset"

@ck2000
Copy link
Author

ck2000 commented Nov 11, 2020

The javascript works fine. The select2 css code is missing.

@tvdeyen
Copy link
Member

tvdeyen commented Nov 13, 2020

The javascript works fine. The select2 css code is missing.

@ck2000 I updated the PR. Please pull the latest version and try again. Thanks for testing 🙏

@ck2000
Copy link
Author

ck2000 commented Nov 13, 2020

The javascript works fine. The select2 css code is missing.

@ck2000 I updated the PR. Please pull the latest version and try again. Thanks for testing 🙏

Works fine. Thank you for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants