initial database schema for seaport #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this for now, but have solicited a few people to take a look and contribute to any possible improvements. |
St4rgarden
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Looks good; here's the reference implementation for helper functions and libraries used in the SeaPort testing suite https://github.com/St4rgarden/BrushInk-SeaPort/blob/main/test/utils/encoding.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleanroom rewrite of a database schema to underlay these models: https://docs.opensea.io/v2.0/reference/model-reference
Changed a bit of the casing to be more consistent, and the types to more closely correlate with the data types coming in and out of the contract.