Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL is sometimes not sent on window activation when KeePass has recently launched #1

Open
Aldaviva opened this issue Nov 11, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Aldaviva
Copy link
Owner

The workaround is usually to activate a different window first and then activate Vivaldi again.

I think this is being caused by the 500 ms debouncing logic, where

  1. the previous request went out before KeePass was running or its web server was listening
  2. KeePass's web server starts
  3. Vivaldi's window is activated, and the extension is informed of this by the external message sent from the Vivaldi first-party extension (custom.js)
  4. this extension skips sending the XHR to KeePass because less than 500 ms has elapsed since the last (failed) request went out, and the URL did not change

It's also possible that the active window detection doesn't always work properly. For example, there may be a race condition between the Vivaldi first-party extension sending the Chromium runtime external message to this extension telling it that a window was activated, and this extension's calls to chrome.windows.getCurrent returning the newly activated window. Losing this race would result in the wrong URL being read.

@Aldaviva Aldaviva added the bug Something isn't working label Nov 11, 2022
@Aldaviva Aldaviva self-assigned this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant