Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Keyed Frame stops on incorrect frames #1

Closed
josephsdaniels opened this issue Feb 13, 2022 · 3 comments
Closed

Find Keyed Frame stops on incorrect frames #1

josephsdaniels opened this issue Feb 13, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@josephsdaniels
Copy link

When I move a keyframe on the timeline, it still stops on the frame that previously had a key when using Find Previous or Find Next to move through the timeline, even though there is no longer a key there.

This is also the case if I make edits or sculpts on a frame in between key poses. Say I have a key pose on frame one and 5. If I edit the first key pose on say frame 2, the next time I step through my animation using Find Keyed Frame it will stop on frame 2 even though there is no key there. Neither re-opening the file nor re-starting blender fixes the issue.

@AldrinMathew AldrinMathew added bug Something isn't working good first issue Good for newcomers labels Feb 13, 2022
@AldrinMathew
Copy link
Owner

This has been fixed @josephsdaniels

Here is the explanation:

The Find Keyed Frame feature was not just considering the actual keyframes present in the current scene. A keyframe will have an x and y coordinate. The x coordinate is indeed the actual value of the keyframe. The y coordinate is the value of the animation or the value that has been keyed.
So when all these values were returned by the function that found keyframes with keyed meshes, it jumped to the wrong frame

@AldrinMathew
Copy link
Owner

Also thanks for the detailed description.
And have a look at #3 . It is a serious issue if you are using dyntopology

@josephsdaniels
Copy link
Author

Thanks so much for these fixes. It's a much smoother experience now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants