Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs when adding HN rss feed #135

Closed
stephen304 opened this issue Apr 25, 2018 · 2 comments
Closed

Hangs when adding HN rss feed #135

stephen304 opened this issue Apr 25, 2018 · 2 comments
Labels

Comments

@stephen304
Copy link

I'm trying to add the feed at https://news.ycombinator.com/rss but Alduin just hangs after I press "Add feed". It doesn't seem to happen with other feeds (I can successfully add the C&H feed, although I need to select RSS instead of Atom even though the C&H feed seems to be an atom feed)

@netsensei
Copy link

Looks like a CORS issue.

Alduin is build with Electron. It's basically running a "website-inside-an-application". Everything you see inside the Alduin window is managed and rendered through Chromium.

Alduin calls the fetch function for making a HTTP requests to HN. Chromium treats that call as if it wer coming from a normal client-side browser context, which will trip CORS validation. In this case, Chromium returns an inaccessible - opaque - HTTP response back to Alduin's application code.

See: https://developers.google.com/web/updates/2015/03/introduction-to-fetch?hl=en

@Xstoudi
Copy link
Member

Xstoudi commented Jul 3, 2023

Will be fixed in next release : request are now executed on native side.

@Xstoudi Xstoudi closed this as completed Jul 3, 2023
@Xstoudi Xstoudi added the bug label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants