-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert from minidom to roxml #22
base: master
Are you sure you want to change the base?
Conversation
Hi @AlecTroemel. I am waiting on this too :-) |
There are some parsing differences between these 2 crates. I wonder if it may impact existing implementations. Did we forget to bump the version? |
@rimutaka hmm.. that could explain why i had to change the Null value config here https://github.com/AlecTroemel/quickxml_to_serde/pull/22/files#diff-a0262fea108af44a98cc49e5eb72641963dd816513f2d0a22eb738fcfed55ebeR353 I'll take another look there, ideally we'd be able to pass tests without making any changes to them |
aha, I think i've fixed the change, tests now pass with no changes from master branch! |
this MR does make the name of this repo incorrect.. Not sure the best way to handle that 🤔 |
I think the version should probably be bumped to |
@AlecTroemel just a note; this branch won't compile with the I also have two changes in behavior while running this branch across my local test suite (after propagating path to
|
match convert_node(&child, config, &path) { | ||
Some(val) => { | ||
let name = &child.tag_name().name().to_string(); | ||
println!("{:?}", name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this println!()
should be removed
another behavioral change I have noticed though I don't see immediately why; is that when using types the it used to come out as |
Any updates on that? |
all tests pass, and generate the same json from
test_xml_files
examplescloses #21