-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hxsggsz 35268942 #6
Conversation
Adorei o PR! Vamos tentar seguir mais esse padrão no projeto! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um pepino chato é que vc commitou o base.scss
na mesma branch e não numa separada, isso é ruim, mas como era só colocar a branch sem mais nada acho que ta safe!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algumas modificações relacionados a styleguide e padrões que vamos adotar.
.github/pull_request_template.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ué, ta resolved, mas o arquivo ainda ta aqui
src/components/preview/index.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mais um marcado como resolved que não foi feito.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nome da pasta é PascalCase
tambem
@@ -0,0 +1,4 @@ | |||
export interface ISwitch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anota isso no nosso styleguide, com excessão de componentes, todo o resto é export na declaração, salvo excessões!
right: 0; | ||
left: 50%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acho q dava pra melhorar, mas ta bom desse jeito!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mais um marcado como resolved que não foi resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eu tinha apagado o arquivo mas todo push que eu faço esse arquivo é enviado pra pr junto com o componente de preview da outra pr por algum motivo
On this pull request i make a toggle social media with a switch component using the checkbox input as a base for it
The toggle social media component
To use this component you need to pass as props the social media name, here is the code example:
The final result:
How to use the switch component on your code:
You will need to pass two props to the component: the checked state as a boolean and the setChecked
here is an example in code how to use it
Final result of the switch component