Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobileDisabled is not used #24

Closed
gotson opened this issue Mar 24, 2021 · 3 comments
Closed

mobileDisabled is not used #24

gotson opened this issue Mar 24, 2021 · 3 comments

Comments

@gotson
Copy link

gotson commented Mar 24, 2021

There is a parameter mobileDisabled but it's not used anywhere in the code. Or did I miss something?

The code and doc would probably require clarification in regards to that parameter and forceDesktopMode, to clearly explain how to make it work on mobile.

For instance the doc mentions that mobileDisableddefaults to false, while it's true in the code. But anyhow this parameter is not used.

@AleeeKoi
Copy link
Owner

Hi @gotson ,
mobileDisabled was deprecated times ago.
Sorry, I need to fix it in the doc...

Anyway, in mobile devices the library is disabled by default. You could set forceDesktopMode = true to activate also on mobile devices.

Thanks

@gotson
Copy link
Author

gotson commented Mar 24, 2021

Thanks, that's what I figured out from the code. You can keep this issue for updating the doc then 😉

@AleeeKoi
Copy link
Owner

Doc updated! 🤟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants