Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance and naming improvements #46

Merged
merged 5 commits into from Oct 19, 2022
Merged

Performance and naming improvements #46

merged 5 commits into from Oct 19, 2022

Conversation

AleksandrHovhannisyan
Copy link
Owner

@AleksandrHovhannisyan AleksandrHovhannisyan commented Oct 18, 2022

  • Instead of consuming the state context internally within each form input group, we now pass down only the data the components need and memoize them to prevent unnecessary re-renders. React dev tools were highlighting lots of re-renders for some of the inputs.
  • Debounces URL updates to fix a console warning.
  • Cleans up code output logic for indentation.
  • Renames api/* => schema/* to match terminology used by libraries like zod and yup. Also renames getValue => parse, etc.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for zen-ptolemy-a47e6d ready!

Name Link
🔨 Latest commit 03da357
🔍 Latest deploy log https://app.netlify.com/sites/zen-ptolemy-a47e6d/deploys/634f2b521f173e000af056a9
😎 Deploy Preview https://deploy-preview-46--zen-ptolemy-a47e6d.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant