Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other storages? #6

Closed
perepicornell opened this issue Mar 15, 2021 · 4 comments
Closed

Support for other storages? #6

perepicornell opened this issue Mar 15, 2021 · 4 comments

Comments

@perepicornell
Copy link

Hi!
Thanks a lot for the package, it's great.

When I tried it it was not working, and then I realized that it was storing the files at a local /svg folder instead of the storage that I have by default, which is s3boto for an s3-like provider I use.

I see your code defining this:

    storage = FileSystemStorage(
        location=settings.MEDIA_ROOT,
        base_url=settings.MEDIA_URL
    )

But to be honest I don't understand django storages well enough as for imagining the next steps to make it compatible.

So I'm sharing it here in case you or someone else can shed some light about how to approach it. Sorry I can't be more useful right now!

@Aleksi44
Copy link
Owner

Hi @perepicornell

Can you test your project with this version:

pip install wagtailsvg==0.0.11

I use django storage myself with this version and like this in my settings :

STATICFILES_STORAGE = 'storages.backends.s3boto3.S3Boto3Storage'

It's possible that the latest version 0.0.13 is broken some things with django-storage.

@perepicornell
Copy link
Author

Hi!
Just tried it, and now it works like a charm!

@Aleksi44
Copy link
Owner

@perepicornell Nice :)

@VanL Do you have any idea why 0.0.13 doesn't work with django-storage?

@zerolab
Copy link

zerolab commented Jun 29, 2021

I suspect the issue stems from the fact that https://github.com/Aleksi44/wagtailsvg/pull/5/files sets the storage explicitly as FileSystemStorage

I see 0.0.14 fixes the issue by reverting that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants