Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] snarkOS aggressively disconnects peers #3152

Closed
HarukaMa opened this issue Mar 4, 2024 · 0 comments 路 Fixed by #3153
Closed

[Bug] snarkOS aggressively disconnects peers #3152

HarukaMa opened this issue Mar 4, 2024 · 0 comments 路 Fixed by #3153
Labels
bug Incorrect or unexpected behavior

Comments

@HarukaMa
Copy link
Contributor

HarukaMa commented Mar 4, 2024

馃悰 Bug Report

SnarkOS reports protocol violation and disconnects when peers send known solutions.

The inbound function returns error when it receives a known solution:
https://github.com/AleoHQ/snarkOS/blob/8be6ac9a3d2c119d2a2282ba74a0d0886a30a521/node/router/src/inbound.rs#L212-L213

However, it will be regarded as a protocol violation:
https://github.com/AleoHQ/snarkOS/blob/8be6ac9a3d2c119d2a2282ba74a0d0886a30a521/node/src/client/router.rs#L116-L122

Steps to Reproduce

Run node with verbosity 5, observe the logs.

2024-03-04T17:36:59.558190Z  WARN snarkos_node::client::router: Disconnecting from '147.192.99.28:4133' - Skipping 'UnconfirmedSolution' from '147.192.99.28:4133'                                                
2024-03-04T17:12:27.078139Z TRACE snarkos_node_router::inbound: Received 'Disconnect' from '195.90.201.199:4133'
2024-03-04T17:12:27.078194Z  WARN snarkos_node::client::router: Disconnecting from '195.90.201.199:4133' - ProtocolViolation

Expected Behavior

Don't return error there. Trace and skip.

Your Environment

@HarukaMa HarukaMa added the bug Incorrect or unexpected behavior label Mar 4, 2024
@HarukaMa HarukaMa changed the title [Bug] [Bug] snarkOS aggressively disconnects peers Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or unexpected behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant