Re-enable noise encryption #2700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaslong
force-pushed
the
feat/noise
branch
2 times, most recently
from
4fa93dc
to
540e5a6
Compare
niklaslong
changed the title
niklaslong
force-pushed
the
feat/noise
branch
2 times, most recently
from
ef25a99
to
b1acd1e
Compare
niklaslong
force-pushed
the
feat/noise
branch
2 times, most recently
from
b1b61aa
to
0b58a77
Compare
niklaslong
force-pushed
the
feat/noise
branch
2 times, most recently
from
a4e20d4
to
cf1f0b4
Compare
niklaslong
force-pushed
the
feat/noise
branch
4 times, most recently
from
ee58479
to
8f8786b
Compare
niklaslong
force-pushed
the
feat/noise
branch
3 times, most recently
from
af524c5
to
1da5ea4
Compare
|
Rebased and updated fuzz targets. |
niklaslong
force-pushed
the
feat/noise
branch
11 times, most recently
from
010bea4
to
1893e23
Compare
niklaslong
force-pushed
the
feat/noise
branch
10 times, most recently
from
e3e0e6a
to
459b29b
Compare
niklaslong
force-pushed
the
feat/noise
branch
from
459b29b
to
620782e
Compare
joske
force-pushed
the
feat/noise
branch
2 times, most recently
from
467d322
to
8d536d9
Compare
|
Deprioritised for mainnet, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces Noise encryption along with some tweaks to the handshaking logic to detect double-connects.
I've also included a fuzz target for the codec.
Testing: I created another branch that includes #2692 and ran a small devnet and successfully bonding new validators. The implementation seems quite stable in normal operations. #2690 should also increase stability.