Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZKS-00] Revert election certificates #3081

Merged
merged 2 commits into from Feb 10, 2024
Merged

Conversation

howardwu
Copy link
Contributor

@howardwu howardwu commented Feb 10, 2024

Motivation

This change was made as part of a potential fix for the BFT, however it became clear we actually do not need it. So we are removing it to bring this back to vanilla Bullshark.

The sister PR can be found here: AleoNet/snarkVM#2343

This was originally a fix intended for Audit Finding: [zksecurity 00] Commit Flow Can Lead to Safety Violation, however it is now unnecessary with the new fixes.

@howardwu howardwu changed the title Revert/election certificates Revert election certificates Feb 10, 2024
@howardwu howardwu marked this pull request as ready for review February 10, 2024 03:44
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howardwu howardwu merged commit e0303d4 into mainnet Feb 10, 2024
11 of 24 checks passed
@howardwu howardwu deleted the revert/election-certificates branch February 10, 2024 03:49
@raychu86 raychu86 changed the title Revert election certificates [zksecurity 00] Revert election certificates Feb 12, 2024
@raychu86 raychu86 changed the title [zksecurity 00] Revert election certificates [ZKS-00] Revert election certificates Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants