[Fix] Limit number of deployments in mempool. #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At 10 deployments we won't run out of memory. At 5 deployments, we won't take too much compute time. We always interweave the verification of some executions and deployments.
vicsn
force-pushed
the
limit_deployments_2
branch
from
fe1f0af
to
be8e6ce
Compare
ljedrz
reviewed
Feb 12, 2024
node/consensus/src/lib.rs
Outdated
Comment on lines
294
to
296
| let mut deployments_queue = self.deployments_queue.lock(); | ||
| // Acquire the lock on the executions queue. | ||
| let mut executions_queue = self.executions_queue.lock(); |
There was a problem hiding this comment.
future consideration: ideally, collections that are always accessed together could be under a single lock (for added performance), though that may require a little bit more type boilerplate
There was a problem hiding this comment.
Made it anyway so Howard can decide: f93060b
Did not implement any further methods for TransactionsQueue to avoid having to add input checking for those methods and to keep it simple.
howardwu
approved these changes
Feb 14, 2024
howardwu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new approach to #2999 with a focus on simplicity and readability.
At 10 deployments at most in the deployments_queue, we won't run out of memory (the network message size is at most 300 MB).
And we will never verify more than 1 deployment sequentially if there are any executions around, making sure we won't take too much compute time.
We always interweave the verification of some executions and deployments.