fix: validator doesn't participate in consensus #3096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the problem is that when the current round is sent to the bft using
bft_sender.send_primary_round_to_bft(current_round).await
, if this returns true, the primary starts to propose batches. The problem is that it also returns true when the storage fails to increment to next round. If this returns false, it fixes the issue (well the one I was seeing, where the 4th node syncs but can't participate in consensus)Test Plan
steps to reproduce (without the fix):
with the fix:
Related PRs
#3074