Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validator doesn't participate in consensus #3096

Merged
merged 1 commit into from Feb 14, 2024

Conversation

joske
Copy link
Contributor

@joske joske commented Feb 14, 2024

Motivation

the problem is that when the current round is sent to the bft using bft_sender.send_primary_round_to_bft(current_round).await, if this returns true, the primary starts to propose batches. The problem is that it also returns true when the storage fails to increment to next round. If this returns false, it fixes the issue (well the one I was seeing, where the 4th node syncs but can't participate in consensus)

Test Plan

steps to reproduce (without the fix):

  • clear the local ledger
  • start 3 nodes and wait for about 30 rounds
  • start 4th node
  • notice that it syncs up, but not quite, and doesn't participate in consensus and keeps on resending an old batch

with the fix:

  • 4th node syncs and starts to participate in consensus

Related PRs

#3074

@joske joske requested a review from howardwu February 14, 2024 19:44
@howardwu howardwu merged commit 48a2d6a into AleoNet:mainnet Feb 14, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants