[Fix] Update is_proposing check
#3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this branch, and this seems to work. On |
howardwu
approved these changes
Feb 20, 2024
howardwu
changed the title
is_proposing check is_proposing check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR attempts to solve the issue where validators are stuck on an old proposal and unable to advance/participate in future rounds of consensus. The current check was preventing the round from advancing if we had a pending proposal, because we were too aggressively assuming the other validators would still sign it. The new logic will now advance the round even if we are proposing if the peer's certificate is already past our proposal round.
If the peer already has a certificate that hit availability threshold, then we can assume they won't be signing for old proposals.
Related to #3074