[Optimize] Cache the latest leader #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. |
ljedrz
force-pushed
the
cache_latest_leader
branch
3 times, most recently
from
a99afaa
to
f20ab4d
Compare
Signed-off-by: ljedrz <ljedrz@gmail.com>
ljedrz
force-pushed
the
cache_latest_leader
branch
from
f20ab4d
to
3161da0
Compare
joske
approved these changes
Feb 22, 2024
SplittyDev
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leader computation is a relatively costly operation (it can take more than 1ms with a 4-member committee), and it is currently called several times for the same round. With a little bit of extra code and with negligible overhead we can cache the latest computed leader and in case of a hit, the leader can be procured 3 orders of magnitude (under 1 µs) faster.
note: this PR has a little bit of overlap (mostly related to dependencies) with #3106